Generate gravatar hash by replacing md5 with sha256 #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate gravatar hash by replacing md5 with sha256
sy-records
reviewed
Feb 19, 2024
| @@ -852,7 +852,8 @@ public static function gravatarUrl( | |||
| } | |||
|
|
|||
| if (!empty($mail)) { | |||
| $url .= md5(strtolower(trim($mail))); | |||
| // https://docs.gravatar.com/general/hash/ Replacing md5 with sha256 | |||
| $url .= hash('sha256', strtolower(trim($mail))); | |||
There was a problem hiding this comment.
如果定义了__TYPECHO_GRAVATAR_PREFIX__，且不支持sha256的话可能就出问题了 🤔
There was a problem hiding this comment.
加参数的话，调用的地方也得加一下。感觉还是用常量定义的好些
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate gravatar hash by replacing md5 with sha256