Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes python 3.12 syntax warning #787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RS2-CN3
Copy link

@RS2-CN3 RS2-CN3 commented May 8, 2024

Hi, I am using this project for my django app but when I upgraded to python 3.12 I was getting SyntaxWarning: invalid escape sequence '\g' from utils/_core.py whenever I started my server.

From 3.6-3.11 this used to be DeprecationWarning but from 3.12 onward this has been upgraded to SyntaxWarning.

@pratyushmittal
Copy link

@twopirllc Hey Kevin, can you please have a look at this PR. It fixes the support for Python 3.12.

@twopirllc
Copy link
Owner

Hello @RS2-CN3,

Nice fix. However, it would be great if you submitted the PR via the development branch instead of main for the fix. If not, I will manually update it as soon as I can.

@pratyushmittal

Noted. But also feel free to update your local copy in the mean time. Or conversely, please use the development version and update that local copy with said modifications until I can make a development push.

Kind Regards
KJ

@RS2-CN3
Copy link
Author

RS2-CN3 commented May 21, 2024

Okay I will do so as soon as i can

@twopirllc
Copy link
Owner

@RS2-CN3

No rush. I appreciate it! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants