Add SO_REUSEPORT support to socket #396
Conversation
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
655bb94
to
232648b
Compare
src/nc_stats.c
Outdated
| @@ -827,7 +828,9 @@ stats_listen(struct stats *st) | |||
| log_error("socket failed: %s", strerror(errno)); | |||
| return NC_ERROR; | |||
| } | |||
|
|
|||
| #if LINUX_VERSION_CODE >= KERNEL_VERSION(3,9,0) | |||
There was a problem hiding this comment.
@ton31337 twemproxy can run on mac or freebsd also. so I think you should check other os too not only linux :)
There was a problem hiding this comment.
@charsyam 👍 of course will fix this, but need to be sure if it's worth to spend more time. I mean if it's planned to be merged or not.
There was a problem hiding this comment.
@charsyam are you able to test this on FreeBSD ? :)
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
3 times, most recently
from
daccbb6
to
0ac411f
Compare
|
change looks great - i need to test this before merging. |
|
+1 |
|
|
|
@manjuraj ping |
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
0ac411f
to
973886c
Compare
Introduce new feature for Twemproxy running on newer kernels. With this feature you are able to do upgrades, restarts without any downtime. Kernel does load balancing between processes with the same host:port pairs. Also, helps running on more than single core. Signed-off-by: Donatas Abraitis <donatas@hostinger.com>
ton31337
force-pushed
the
feature/add_socket_reuseport
branch
from
973886c
to
3c9cec1
Compare
This seems to work locally - testing since I haven't used SO_REUSEPORT elsewhere. I can start two nutcracker instances for memcached with
|
Add SO_REUSEPORT support to socket. Introduce new feature for Twemproxy running on newer kernels. With this feature you are able to do upgrades, restarts without any downtime. Kernel does load balancing between processes with the same host:port pairs.