Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables #1813

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused variables #1813

wants to merge 2 commits into from

Conversation

mzarchi
Copy link

@mzarchi mzarchi commented Apr 30, 2023

There were two variables in the code that were used only once, out of respect for Twitter developers, I removed this variable and entered the values directly into dict.

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2023

CLA assistant check
All committers have signed the CLA.

@ubergard
Copy link

LGTM

@gran4
Copy link

gran4 commented May 1, 2023

Next time, keep in mind it is usually better to keep the git history clean. Your commit shows that the whole section was deleted then re-added. I guess its fine for now. lgtm

@Risae
Copy link

Risae commented May 1, 2023

Next time, keep in mind it is usually better to keep the git history clean. Your commit shows that the whole section was deleted then re-added. I guess its fine for now. lgtm

That is because he moved the whole code section on step further to the right, instead of just editing the values that needed to be edited. @mzarchi i recommend fixing your broken code indentation so the twitter devs have a proper change diff.

@mzarchi
Copy link
Author

mzarchi commented May 1, 2023

Next time, keep in mind it is usually better to keep the git history clean. Your commit shows that the whole section was deleted then re-added. I guess its fine for now. lgtm

Ok, thanks for it ❤️

@mzarchi
Copy link
Author

mzarchi commented May 1, 2023

Next time, keep in mind it is usually better to keep the git history clean. Your commit shows that the whole section was deleted then re-added. I guess its fine for now. lgtm

That is because he moved the whole code section on step further to the right, instead of just editing the values that needed to be edited. @mzarchi i recommend fixing your broken code indentation so the twitter devs have a proper change diff.

Be sure and thanks for the beauty point you said ❤️

@RiteshShakya
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants