Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade to libthrift 0.19.0 #367

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Mar 12, 2024

  1. WIP: Upgrade to libthrift 0.19.0

    Scrooge's `TArrayByteTransport` and `TReusableMemoryTransport` classes both
    extend libthrift's abstract `org.apache.thrift.transport.TTransport` class.
    That class gained 3 new abstract members with apache/thrift#2191
    (September 2020), released with libthrift v0.14.0 (February 2021). Consequently,
    both classes currently fail to compile, due to missing implementations for these
    methods:
    
    def checkReadBytesAvailable(x$1: Long): Unit = ???
    def getConfiguration(): org.apache.thrift.TConfiguration = ???
    def updateKnownMessageSize(x$1: Long): Unit = ???
    
    Note that Snyk PR twitter#357 updates only
    one of several files that needs to be updated for a libthrift upgrade, and
    the most important file is probably `build.sbt`, not `demos/scrooge-maven-demo/pom.xml`.
    rtyley committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6766fbe View commit details
    Browse the repository at this point in the history