New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate scalding from scalariform to scalafmt #1953
Conversation
Nice! |
Are we sure this is based on the latest code changes we landed on develop? It's very hard to review the whole diff. |
looks like one of the job failed. Also, I wonder, are we using |
Yes, I applied it on top of develop. But given build failures I decided to split this change into config & preparation, and actual reformatting diff which is going to be just reformatting (and making CI fail if something not formatted properly). Now this change contains:
|
Scala community migrated of scalariform towards scalafmt during last couple of years.
In this PR I've replaced scalariform with scalafmt in Scalding, used scalafmt config from algebird, and reformatted scalding repo.
I'm planning to follow up with another PR to enable scalafmt check on CI so it would be impossible to merge not formatted code.