Skip to content

Commit

Permalink
The test target "finagle/finagle-thriftmux/src/test/scala:scala" is f…
Browse files Browse the repository at this point in the history
…ailing too often in master in CI.

Summary:
Problem:

The test target "finagle/finagle-thriftmux/src/test/scala:scala" is failing too often in master in CI.

Logs available here:

Known to fail ticket: [CSL-12415](https://jira.twitter.biz/browse/CSL-12415)

Solution:

It has been marked "known-to-fail" in the BUILD file

Result:

This will cause it to be skipped in future builds, and its failures ignored in submit queue. This implies that code changes that further break this test will not be prevented from being submitted to the master branch, until the problem is fixed and the test is no longer marked known-to-fail.

Reviewers: O865 source:/finagle/finagle-thriftmux/!

Differential Revision: https://phabricator.twitter.biz/D1108489

TBR=true
  • Loading branch information
Automated go/ktf Flagger authored and jenkins committed Nov 4, 2023
1 parent 424d91d commit 92c7d4d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion finagle-thriftmux/src/test/scala/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ junit_tests(
sources = ["**/*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
tags = ["bazel-compatible"],
tags = [
"bazel-compatible",
"known-to-fail-jira:CSL-12415",
],
dependencies = [
"3rdparty/jvm/junit",
"3rdparty/jvm/org/apache/thrift:libthrift",
Expand Down

0 comments on commit 92c7d4d

Please sign in to comment.