Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several bugs in tiologparse #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix several bugs in tiologparse #8

wants to merge 3 commits into from

Conversation

JoepdeJong
Copy link
Contributor

@JoepdeJong JoepdeJong commented Apr 17, 2024 •
edited

  • Adds the first line to the combined output. This line is currently skipped.
  • Removes .pop of datarates and finaltimes on missing timing metadata, since these are undefined. Fixes KeyError: '/0/'
  • Fixes exit when using --separate flag.

@JoepdeJong
Add first line
d3d6bf4 
The first line is currently skipped
@JoepdeJong
Remove pop of datarates and finalrates
2d9a034 
`datarates` and `finalrates` are undefined for `route` when `route` has no `firsttime`
@JoepdeJong JoepdeJong changed the title Add first line to combined file WIP: Several changes Apr 17, 2024
@JoepdeJong JoepdeJong changed the title WIP: Several changes Fix several bugs in tiologparse Apr 17, 2024
@JoepdeJong
Copy link
Contributor Author

This PR removes several bugs in the tiologparse script. @tkornack Is it possible to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JoepdeJong