Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add; Dockerfile for running inside a container #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

karthikmuralidharan
Copy link

For some weird reason I wasn't able to successfully install all the dependencies on my macOS 10.12.5 (16F73) with Node versions v8.1.2, v8.0.0, v7.10.0.

I kept constantly receiving this error:

29396 verbose stack Error: sip.js@0.7.5 postinstall: `cd src/Grammar && mkdir -p dist && pegjs --extra-options-file peg.json src/Grammar.pegjs dist/Grammar

I didn't try to dig any deeper into this and simply created a Dockerfile and ran a container to see if it had to do something with my current OS environment. It worked!! So I thought it might be useful for somebody else.

@markandrus
Copy link
Contributor

Interesting—thanks for the contribution, @karthikmuralidharan. How would you imagine the README.md changing to describe this?

Also, FWIW, the pegjs issue should be solved as of twilio-video.js@1.2.2.

@karthikmuralidharan
Copy link
Author

@markandrus I forgot to reply :). I have updated the README to provide instructions on building the image and running the container and have made some small tweaks to the Dockerfile as well.

@scarroll32
Copy link

bump Twilio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants