Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VBLOCKS-2954] Update @twilio/voice-errors to 1.5.0 #264

Merged
merged 3 commits into from May 13, 2024

Conversation

mhuynh5757
Copy link
Collaborator

@mhuynh5757 mhuynh5757 commented May 7, 2024

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR updates the voice error dependency to the latest version and generates the new callmessageeventmessagetype error for use in the SDK.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

Copy link
Collaborator

@charliesantos charliesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍

@mhuynh5757 mhuynh5757 marked this pull request as ready for review May 13, 2024 20:42
Comment on lines +4 to +18
====================

Changes
-------

- The `CallMessage` API has changed. The type of `Call.Message.messageType` formerly had type `Call.MessageType`. The `Call.MessageType` enumeration has been removed and `Call.Message.messageType` is now of type `string`. The `CallMessage` interface is now as follows:
```ts
interface Call.Message {
content: any;
contentType?: string;
messageType: string;
voiceEventSid?: string;
}
```
When sending a `Call.Message` using `call.sendMessage()`, if the message type is invalid or not understood by Twilio, an error response will be sent. See this [error page](https://www.twilio.com/docs/api/errors/31210) for further details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changelog. We'll probably need to revisit this before going GA

@mhuynh5757 mhuynh5757 merged commit b46f2a9 into feature/eventing_1.5 May 13, 2024
7 checks passed
@mhuynh5757 mhuynh5757 deleted the update-twilio-errors-to-1.5.0 branch May 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants