Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add AI Assistants icon #3820

Merged
merged 2 commits into from Mar 18, 2024
Merged

feat(icons): add AI Assistants icon #3820

merged 2 commits into from Mar 18, 2024

Conversation

dkundel
Copy link
Member

@dkundel dkundel commented Mar 14, 2024

Feel free to Slack me for details.

Also the contribution guide said to run yarn workspace @twilio-paste/icons convert which ended up in deleting all the other icons other than mine. This PR instead used the following commands which looked more right:

yarn workspace @twilio-paste/icons convert-new
yarn workspace @twilio-paste/icons list-icons

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel requested a review from a team as a code owner March 14, 2024 23:15
@dkundel dkundel requested a review from serifluous March 14, 2024 23:15
Copy link

stackblitz bot commented Mar 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: b430131

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@twilio-paste/icons Minor
@twilio-paste/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 14, 2024
Copy link

vercel bot commented Mar 14, 2024

@dkundel is attempting to deploy a commit to the Twilio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

nx-cloud bot commented Mar 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b430131. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Mar 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b430131:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

Copy link
Collaborator

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, and good callout on our README!

Were you still adding the responsive behavior or should we ship this as is?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2024
Copy link

vercel bot commented Mar 18, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/concepts/teams/roles-and-permissions

@TheSisb TheSisb merged commit c04a38a into twilio-labs:main Mar 18, 2024
12 of 21 checks passed
@TwilioPasteBot TwilioPasteBot mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants