Repo now out of date #478
Open
Repo now out of date #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script will forward a incoming MMS image as an attachment to a email using Sendgrid.
Added warning in README
Updated README with waring message.
Touched up appearance of the URL
BlakePetersen
requested changes
Jan 10, 2024
Edited "SMS" to "MMS"
Changed "Blog" to "blog"
|
Could you please add the out of date info to the main readme as well? Thank you |
Added EOF \n
"ecosystem are migrating" to "ecosystem is migrating"
|
I see it only under forward-message-sendgrid/README.md |
2 tasks
|
@dooley1001 thank you, I have replied to #501 . I believe the warning here might also be redundant. Otherwise it looks good. (Note I have not checked if the function works, we trust the owning team to do that) I would also encourage you to check out the GH actions build results |
Warning redundant and removed. Simply just included text stating repo out of date
|
No worries @makserik - I have removed the "warning" but left the main text. Are we all good to merge ? |
makserik
reviewed
Mar 15, 2024
makserik
reviewed
Mar 15, 2024
Removed the words "out of date" and clarified the JS migration
makserik
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the release of Node v18, Node is migrating over from the old CommonJS (CJS) standard to the newer, ES Modules (ESM) standard. As a result the current snippets are out of date - https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1
More info/context - https://www.twilio.com/docs/serverless/functions-assets/faq#how-can-i-use-an-es-module-in-my-function
Checklist
npm testlocally and it passed without errors.