feature #4011 Add PHP 8.4 support (fabpot)

This PR was squashed before being merged into the 3.x branch. Discussion ---------- Add PHP 8.4 support Commits ------- fdfc5dd Fix compat with PHP 8.4 11511e1 Add PHP 8.4 to CI
twigphp · Apr 16, 2024 · 8150b68 · 8150b68
2 parents 6091e7d + fdfc5dd
commit 8150b68
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,6 +28,7 @@ jobs:
                     - '8.1'
                     - '8.2'
                     - '8.3'
+                    - '8.4'
 
         steps:
             - name: "Checkout code"
@@ -79,6 +80,7 @@ jobs:
                     - '8.1'
                     - '8.2'
                     - '8.3'
+                    - '8.4'
                 extension:
                     - 'cache-extra'
                     - 'cssinliner-extra'

diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 # 3.9.0 (2024-XX-XX)
 
+ * Add support for PHP 8.4
  * Deprecate AbstractNodeVisitor
  * Deprecate passing Template to Environment::resolveTemplate(), Environment::load(), and Template::loadTemplate()
  * Add a new "yield" mode for output generation;

diff --git a/src/Node/Expression/CallExpression.php b/src/Node/Expression/CallExpression.php
@@ -297,7 +297,7 @@ private function reflectCallable($callable)
         }
         $r = new \ReflectionFunction($closure);
 
-        if (str_contains($r->name, '{closure}')) {
+        if (str_contains($r->name, '{closure')) {
             return $this->reflector = [$r, $callable, 'Closure'];
         }