Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints #1828

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Add type hints #1828

wants to merge 49 commits into from

Conversation

Harmon758
Copy link
Member

@Harmon758 Harmon758 commented Feb 26, 2022 •
edited

Resolves #1407

This adds a types dependency extra, requiring types-oauthlib, types-requests, and typing-extensions.

@Harmon758 Harmon758 added Feature This is regarding a new feature Improvement This is regarding an improvement to an existing feature Documentation This is regarding the library's documentation labels Feb 26, 2022
@Harmon758 Harmon758 added this to the 4.x milestone Feb 26, 2022
@Harmon758 Harmon758 self-assigned this Feb 26, 2022
@Harmon758 Harmon758 mentioned this pull request Feb 26, 2022
Open
Harmon758 and others added 12 commits April 4, 2022 15:06
@Harmon758
Merge branch 'type-hints' into add_bit_type_hint
6260246
@eggplants @Harmon758
Update .github/workflows/test.yml
554a83b 
Co-authored-by: Harmon <Harmon758@gmail.com>
@eggplants @Harmon758
Update .github/workflows/test.yml
ceb5ef3 
Co-authored-by: Harmon <Harmon758@gmail.com>
@eggplants @Harmon758
Update tweepy/auth.py
ed152b3 
Co-authored-by: Harmon <Harmon758@gmail.com>
@Harmon758
Move typing-extensions requirement to new types extra
ca7f554
@eggplants
fix: use __future__.annotations
ed58b61
@eggplants
Merge branch 'type-hints' into add_bit_type_hint
d4892ab
@eggplants
add: install types-extra in ci
39a2535
@Harmon758
Improve order of requirements for types extra
853ba19
@Harmon758
Improve __future__ import formatting in cache.py
5b91003
@Harmon758
Improve __future__ import formatting in streaming.py
ba5cb5c
@Harmon758
Merge pull request #1840 from eggplants/add_bit_type_hint
100770c 
Set up mypy and fix mypy errors (non-strict)
@Harmon758 Harmon758 added the Tests This is regarding the library's tests label Apr 5, 2022
@eggplants
Copy link

To provide type hints to library users, you have to add py.typed marker.
https://peps.python.org/pep-0561/#packaging-type-information

@Harmon758
Copy link
Member Author

Yup, I plan on doing that when type hinting (i.e. this branch / PR) is more complete.

@hunterhector hunterhector mentioned this pull request Apr 12, 2022
Merged
@bhaskar2443053 bhaskar2443053 mentioned this pull request Apr 13, 2022
Open
@Viicos
Copy link

Viicos commented Jan 11, 2023 •
edited

@Harmon758 any news on this PR? I'd like to contribute to this if you don't have time. Do you think we could merge this one? Then we'll be able to make multiple PRs in chunks to add missing types :)

@Harmon758
Copy link
Member Author

This is still a draft PR.
Feel free to PR to the branch. If your PR gets merged, then it'll automatically become part of this PR, since this PR is to merge the branch into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Harmon758 Harmon758

Labels
Documentation This is regarding the library's documentation Feature This is regarding a new feature Improvement This is regarding an improvement to an existing feature Tests This is regarding the library's tests
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Type Hints
3 participants
@Harmon758 @eggplants @Viicos