Fix #1407 by adding type hints to the library #1759
Conversation
| @@ -66,8 +68,17 @@ def __init__(self, consumer_key, consumer_secret, access_token, | |||
| f"Tweepy/{tweepy.__version__}" | |||
| ) | |||
|
|
|||
| async def _connect(self, method, endpoint, params={}, headers=None, | |||
There was a problem hiding this comment.
This is not related to type hints but this default value params={} can be potentially a cause of future bugs. As you may know, default values of method arguments can be reused. Setting mutable objects can result in sharing the same objects among multiple method calls.
|
I will resolve the CI builds shortly! Also, I know this is a very large PR. If the project maintainers would like to start with a small potion of changes, please feel free to close this and take only some parts of this PR step by step. |
seratch
force-pushed
the
issue-1407-type-hints
branch
from
a84ae7a
to
71f96f0
Compare
seratch
force-pushed
the
issue-1407-type-hints
branch
from
b578c73
to
bc8a642
Compare
|
馃憢 This pull request is now ready for reviews! |
|
As the team is not planning to merge this in the short term, let me switch this PR to draft mode. If the maintainers would like to close this in the future, please feel free to do so. See also: #1407 (comment) |
|
Closing this PR as the team prefers smaller PRs. For context: #1407 (comment) |
Harmon758
added
the
Improvement
This pull request resolves #1407 by adding type hints to this library! Sorry for sending a large PR 馃檱