fix asyncio timeout error when getting rate limit, status code 420 #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jai-dewani
reviewed
Sep 13, 2021
| @@ -3,6 +3,7 @@ | |||
| # See LICENSE for details. | |||
|
|
|||
| import asyncio | |||
| from asyncio import TimeoutError | |||
There was a problem hiding this comment.
This import won't be required as you have referenced TimeoutError as asyncio.TimeoutError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves handle connection errors when asynchronous streaming.
asyncio runs into timeout error if stream reaches rate limit (status_code 420). This is similar to 68e19cc