Improve RedisCache & cache doc #1234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylepw
force-pushed
the
rediscache
branch
6 times, most recently
from
b0c7b2a
to
6973423
Compare
Harmon758
force-pushed
the
master
branch
5 times, most recently
from
cf54e31
to
d538993
Compare
Harmon758
added
Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made
RedisCachemore efficient/clean with less calls to the client and more Redis-specific logic. Alltests.test_api.TweepyCacheTeststests pass with Redis server running on 127.0.0.1:11211 as specified.I also added
RedisCacheto thetweepynamespace and the names of available caches toapi.rstto clarify usage.Let me know if there's anything else I should do.