Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing Accordion component in the list of JS components #39980

Merged
merged 1 commit into from
May 25, 2024

Conversation

hannahiss
Copy link
Contributor

@hannahiss hannahiss commented May 14, 2024

Description

Add missing Accordion component in the list of JS components (inheriting of Collapse)

Motivation & Context

Accordion is inheriting from Collapse plugin, so collapse.js should be imported in order to make Accordions work correctly (in case of a js optimized import)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@hannahiss hannahiss marked this pull request as ready for review May 14, 2024 11:39
@julien-deramond julien-deramond self-requested a review May 14, 2024 11:42
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @hannahiss! LGTM

@julien-deramond julien-deramond merged commit 7ff271b into twbs:main May 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants