Feature/conflit package #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the key id from when only one secret/algorithm is supplied
When only one algorithm is passed into the configuration but multiple secrets are provided the algorithm
array then needs to be manipulated into a key value store, using the key from the secrets list and the
algorithm being used for the value.
for example:
```
[
'secret' => [
'foo' => 'keepItSecret',
'bar' => 'tooManySecrets',
],
'algorithm' => [
'HS256',
],
]
```
will become
```
[
'secret' => [
'foo' => 'keepItSecret',
'bar' => 'tooManySecrets',
],
'algorithm' => [
'foo' => 'HS256',
'bar' => 'HS256',
],
]
```
Updatig the readme to explain whe the KID is now needed when passing when decodig the token also why the token need the KID to be set in the header
Make the package conflict with `tuupola/slim-jwt-auth`
Pointing references to this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making package conflict with tuupola/slim-jwt-auth and updating the documentation to make it explicitly clear have changes need to be made.