Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update php jwt use php8 #246

Open
wants to merge 13 commits into
base: 3.x
Choose a base branch
from

Conversation

gabrielberthier
Copy link

Open support for PHP versions above 8.0 and include php-jwt ^6.0.
Some refactors were made in order to use some features in the future as named parameters, typed properties and so on.
Since using multiple keys are not usual, I personally preferred to remove support for this feature, as it usually leads to difficulty in regard of maintaining keys secure and less prone to misleading behaviour.

@gabrielberthier
Copy link
Author

Updated codebase in order to still use multiple keys.

@esetnik
Copy link

esetnik commented Dec 1, 2023

@tuupola are you looking for maintainers? Seems like this PR solves a bunch of the compatibility issues.

@tuupola
Copy link
Owner

tuupola commented Dec 1, 2023

Actually I am pondering giving away maintainership of some of the PHP projects including tuupola/slim-jwt-auth and tuupola/slim-basic-auth. Currently paid work comes first and paid work is mostly Kubernetes and stuff.

@esetnik
Copy link

esetnik commented Dec 12, 2023

Hi @tuupola I would be interested in joining as a maintainer on this project to help move it forward. Please let me know if that's something you'd like.

@gabrielberthier
Copy link
Author

In case I can help with something else, let me know. Also, if there is more to implement at this PR, I'd be glad to do it as well.

@zwalden
Copy link

zwalden commented Jan 23, 2024

@tuupola any reason this hasn't been moved forward?

Is there any help needed here to push this forward?

Happy to lend some assistance if helpful.

@zluiten
Copy link

zluiten commented Feb 21, 2024

Such a shame to see this project die :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants