Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading firebase/php-jwt to v6 #225

Closed
wants to merge 8 commits into from
Closed

Upgrading firebase/php-jwt to v6 #225

wants to merge 8 commits into from

Commits on Dec 17, 2023

  1. Dropping support for older version of firebase/php-jwt

    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    781692b View commit details
    Browse the repository at this point in the history

  2. Creating key objects to pass to JWT::decode

    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d07a9cb View commit details
    Browse the repository at this point in the history

  3. Fixing failing unit tests after upgrade of firebase/php-jwt

    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d423545 View commit details
    Browse the repository at this point in the history

  4. Adding docblock to createKeysFromAlgorithms for better typehinting

    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    b3ed450 View commit details
    Browse the repository at this point in the history

  5. Reverting changes to unit tests 

    Removing the key id from when only one secret/algorithm is supplied
    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0d3615c View commit details
    Browse the repository at this point in the history

  6. Manipulating algorithm in hydrator 

    When only one algorithm is passed into the configuration but multiple secrets are provided the algorithm
array then needs to be manipulated into a key value store, using the key from the secrets list and the
algorithm being used for the value.

for example:
```
[
    'secret' => [
        'foo' => 'keepItSecret',
        'bar' => 'tooManySecrets',
    ],
    'algorithm' => [
        'HS256',
    ],
]
```

will become
```
[
    'secret' => [
        'foo' => 'keepItSecret',
        'bar' => 'tooManySecrets',
    ],
    'algorithm' => [
        'foo' => 'HS256',
        'bar' => 'HS256',
    ],
]
```
    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    6346d2f View commit details
    Browse the repository at this point in the history

  7. Updating docs to explain change in behavour 

    Updatig the readme to explain whe the KID is now needed when passing
when decodig the token also why the token need the KID to be set in the
header
    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    2c25fc2 View commit details
    Browse the repository at this point in the history

  8. Fixing type warnings form phpstan

    @JimTools
    JimTools committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    3e9924b View commit details
    Browse the repository at this point in the history