Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaks fix #354

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Leaks fix #354

wants to merge 2 commits into from

Conversation

denar90
Copy link

@denar90 denar90 commented Nov 4, 2016

Added:

  • event namespace
  • destroy method

TL;TR

I created simple example and made some profiling.

mojotech html 2016-11-04 12-58-45

mojotech html 2016-11-04 13-17-29

Here some example, which I used but I've done all work locally to reduce influence by jsfiddle or smth.

After destroying container with images, number of listeners more then at the beginning, also if look a second screen resize, scroll event listeners are present.

Another problem is namespaces, if we want to do destroy it's not possible without events namespaces.

So results of implemented solution are below and example is here.

mojotech html 2016-11-04 13-08-04

mojotech html 2016-11-04 13-11-51

@tuupola tuupola self-assigned this Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants