Remove the lazyload data attribute after the image has been loaded #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the lazyload data attribute after loading the image we can select those image with a CSS selector :not([data-original]).
This is especially useful when images are flexible (width: 100%, height: auto).
Currently there is a bug if the images are of flexible width with height set to auto. When the base64 encoded placeholder is placed, the height: auto makes the height the same amount as width, because it's a 1 per 1 pixel image. That makes the page jump when you scroll the page down to top (try to scroll down on a page, and then hit refresh).
With this feature, we can apply the height: auto only to "loaded" images and that will fix this issue.