@tus/gcs-store: fix multichunk uploads #612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548.
Multichunk uploads are broken starting from @google-cloud/storage v7.6. The reason is that this PR introduces a CRC32 check if
File.createWriteStream
is called with anoffset
param set.Since tus-node-server does not rely on the internal resumable upload feature of GCS (which was actually broken below 7.6), there is no need to create the stream with the offset param at all. See docs: https://googleapis.dev/nodejs/storage/latest/global.html#CreateWriteStreamOptions