Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to setup tox with pyenv to contributing page #241 #251

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tonnydourado
Copy link

Adds some instructions on how to get tox and pyenv to work together, solving #241. Turns out you have to enable all versions required by tox with pyenv global .

I put the instructions in the tox know issues section, and create some sub-headers for that and for man page creation instructions. Is that a good place to put it, or should I create a different section for the pyenv issue?

adourado added 2 commits October 11, 2017 13:27
Also added separated sessions for issues with tox and man page
generation.
@tonnydourado
Copy link
Author

I also found an issue when building the docs for this, seems like sphinx latest version breaks recommonmark, so I raised it here: #252

@turicas
Copy link
Owner

turicas commented Oct 11, 2017

@tonnydourado, thanks!
Note: tox must be installed in a virtualenv not created by pyenv (this use case is for the CI -- a regular developer would use a virtualenv with Python3.6 and run tests with coverage erase && nosetests -dsv --with-yanc --with-coverage --cover-package rows).
@tonnydourado could you please replace make test with this command above also?

adourado added 2 commits October 11, 2017 16:09
Also added a new make target to run the tests on multiple python
versions with tox.
@turicas turicas force-pushed the develop branch 2 times, most recently from fa144f0 to bbb2c57 Compare November 30, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants