Feature/24 pandas plugin #137
Conversation
|
@rhenanbartels, thanks for your PR! I'm going to review it now, but you need to rebase since there are some conflicts between your branch and the current |
rows/__init__.py
Outdated
| @@ -29,6 +29,7 @@ | |||
| from rows.plugins._json import import_from_json, export_to_json | |||
| from rows.plugins.csv import import_from_csv, export_to_csv | |||
| from rows.plugins.txt import export_to_txt | |||
| from rows.plugins._pandas import import_from_pandas | |||
There was a problem hiding this comment.
As pandas is an optional dependency to rows, you need to put this import inside a try/except clause. Need also to import export_to_pandas.
|
@rhenanbartels, I just finished the code review. Please address the changes. ;-) Since this is the first plugin that does not use serialization/deserialization from/to a file (it just changes objects in memory), I don't know if the API should be the same. Thinking in maybe put it inside |
rhenanbartels
force-pushed
the
feature/24-pandas-plugin
branch
from
af1510c
to
8a2365f
Compare
|
Yes, I was thinking about that, maybe a |
| yield list(data_frame) | ||
|
|
||
| for _, row in data_frame.iterrows(): | ||
| yield dataframe_row_to_list(row) |
| yield list(data_frame) | ||
|
|
||
| for _, row in data_frame.iterrows(): | ||
| yield dataframe_row_to_list(row) |
turicas
force-pushed
the
develop
branch
2 times, most recently
from
fa144f0
to
bbb2c57
Compare
Hi Álvaro, I've just finish the code to import/export from/to pandas DataFrame. Can you please review it?
Thanks in advance!