Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Widget Extension support to AppClips #6287

Merged
merged 4 commits into from
May 16, 2024

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented May 15, 2024

Short description πŸ“

Tuist doesn't support defining widget extensions for app clips. This PR adds support for it.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@pepicrft pepicrft changed the title Adds widget extension support to AppClips Add Widget Extension support to AppClips May 15, 2024
@pepicrft pepicrft self-assigned this May 15, 2024
@pepicrft pepicrft changed the title Add Widget Extension support to AppClips [WIP] Add Widget Extension support to AppClips May 15, 2024
@pepicrft pepicrft added the changelog:added PR will be listed in the Added section of CHANGELOG label May 15, 2024
@pepicrft pepicrft changed the title [WIP] Add Widget Extension support to AppClips Add Widget Extension support to AppClips May 15, 2024
Copy link
Collaborator

@danieleformichelli danieleformichelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we extend the ios_app_with_appclip instead of creating a brand new fixture?

@pepicrft
Copy link
Contributor Author

Can't we extend the ios_app_with_appclip instead of creating a brand new fixture?

Yes! I'll do that instead.

@danieleformichelli danieleformichelli enabled auto-merge (squash) May 16, 2024 10:26
@danieleformichelli danieleformichelli merged commit 361c497 into main May 16, 2024
8 checks passed
@danieleformichelli danieleformichelli deleted the feature/app-clip-live-activity branch May 16, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added PR will be listed in the Added section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants