NAS-128891 / 24.10 / Remove the logic for creating swap partitions

[yocalebo]

The remnants of this legacy behavior lurks in eldritch obscurity. Those who dare to comprehend its incomprehensible logic fall into a deep state of despair. As I delved into the tangled syntax where logic intertwines with madness, trying to remove this forbidden code seemed to resist, as if it were a living, breathing entity, guarding its existence through screens flickering with cryptic errors and warnings that chill the spine. Alas, the victor of this battle goes to sanity. The war, however, is not over. For this code is a labyrinthine whose tentacles stretch deep into the very fabric of TrueNAS. More changes will be needed but one must start somewhere.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128891

[sonicaj]

The remnants of this legacy behavior lurks in eldritch obscurity. Those who dare to comprehend its incomprehensible logic fall into a deep state of despair. As I delved into the tangled syntax where logic intertwines with madness, trying to remove this forbidden code seemed to resist, as if it were a living, breathing entity, guarding its existence through screens flickering with cryptic errors and warnings that chill the spine. Alas, the victor of this battle goes to sanity. The war, however, is not over. For this code is a labyrinthine whose tentacles stretch deep into the very fabric of TrueNAS. More changes will be needed but one must start somewhere.

Really nice text :D

[yocalebo]

Tests are passing and extra care has been given to ensure nothing has changed wrt to writing partitions in optimal alignment. (We depend on libparted to do this for us btw, no reason to have extra logic on our side)

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.