NAS-128723 / 24.10 / Enable cgroups plugin #13641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qubad786
reviewed
May 2, 2024
src/middlewared/middlewared/etc_files/netdata/netdata.conf.mako
Outdated
Show resolved
Hide resolved
bugclerk
changed the title
|
@william-gr can you look at this please? I have restricted cgroups plugin by applying a filter because it retrieves lots of stats - i think the current one defined should cover the cases we want..you can look at the approximation changes to get an idea on what charts would be retrieved |
william-gr
commented
May 14, 2024
Qubad786
force-pushed
the
issues/enable_cgroups
branch
from
19f42c5
to
e31c785
Compare
cgroups plugin enabled useful stats (CPU, Memory and Disk activity) for systemd services and VMs. Overhead of this plugin seems to be minimal to always enable it. In the future we might consider making the plugins configurable. This plugin was research as part of SOLN-230.
Qubad786
force-pushed
the
issues/enable_cgroups
branch
from
e31c785
to
a0b8bdf
Compare
Qubad786
approved these changes
May 17, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgroups plugin enabled useful stats (CPU, Memory and Disk activity) for systemd services and VMs.
Overhead of this plugin seems to be minimal to always enable it.
In the future we might consider making the plugins configurable.
This plugin was research as part of SOLN-230.