Add framework for testing TrueNAS spaces #13216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a basic framework for creating tests for TrueNAS spaces. At present it only configures networking and pools and generates a debug. Cleanup functions still need to be written, but that will be part of overall design process for spaces. The stubs are left commented out as an indicator for where to place the separate cleanup and teardown routines.
|
Code is very similar to what you and I wrote for the other feature that shall not be named 😄 , so I'd say this looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a basic framework for creating tests for TrueNAS spaces. At present it only configures networking and pools and generates a debug. Cleanup functions still need to be written, but that will be part of overall design process for spaces. The stubs are left commented out as an indicator for where to place the separate cleanup and teardown routines.