NAS-127251 / 24.10 / Add pytest markers for more intelligent runs #13041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
configurable-testing
branch
from
f32f2a2
to
eaf74c3
Compare
This commit adds basic framework for setting custom markers in our API tests. They can either be set globally for the module via `pytestmark = pytest.mark.smb` and multiple for module `pytestmark = [pytest.mark.fs, pytest.mark.slow]` or via test-specific decorator `@pytest.mark.smb` Long-running tests (more than a couple of minutes) should be marked as `slow` so that they can be skipped in incremental builds.
anodos325
force-pushed
the
configurable-testing
branch
from
25b2a4f
to
90ebf72
Compare
bugclerk
changed the title
mgrimesix
reviewed
Feb 7, 2024
| @@ -37,6 +37,7 @@ | |||
| --interface <interface> - The interface that TrueNAS is run one | |||
|
|
|||
| Optional option | |||
| --markers "smb or nfs" - Markers to run | |||
There was a problem hiding this comment.
Not easy to indicate the format. Maybe
--markers "<markers to run>" - Quoted list separated by 'or', e.g. "smb or nfs". See pytest.ini for list of markers.
|
What would the runtest option look like if I wanted to run 'nfs' and tests without 'slow' markings only? |
themylogin
reviewed
Feb 9, 2024
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| from middlewared.test.integration.assets.roles import common_checks | |||
|
|
|||
| pytestmark = [pytest.mark.vm, pytest.mark.slow] | |||
|
Can we fail the whole test suite if some test file does not have any of the markers? |
themylogin
reviewed
Feb 9, 2024
| @@ -123,6 +126,8 @@ | |||
| callargs.append('-s') | |||
| elif output == '--tests': | |||
| tests.extend(arg.split(',')) | |||
| elif output == '--markers': | |||
| markers.extend(['-m', f'base or {arg}']) | |||
There was a problem hiding this comment.
If arg can be a logic expression shouldn't we enclose it in parenthesis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic framework for setting custom markers in our API tests. They can either be set globally for the module via
pytestmark = pytest.mark.smband multiple for module
pytestmark = [pytest.mark.fs, pytest.mark.slow]or via test-specific decorator
@pytest.mark.smbLong-running tests (more than a couple of minutes) should be marked as
slowso that they can be skipped in incremental builds.New markers can be added to the pytest.ini file. If someone feels particularly ambitious they can enhance in the future by adding a parser to assign markers based on test file names.