NAS-125487 / 24.10 / Use stderr from zectl failures for CallError #12614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zectl command on failure conditions will print to stderr rather than stdout. This means we were losing information about errors on bootenv operations.
bugclerk
changed the title
bmeagherix
approved these changes
Dec 1, 2023
sonicaj
approved these changes
Dec 3, 2023
yocalebo
reviewed
Dec 4, 2023
| @@ -165,7 +165,7 @@ def activate(self, oid): | |||
| try: | |||
| subprocess.run([self.BE_TOOL, 'activate', oid], capture_output=True, text=True, check=True) | |||
There was a problem hiding this comment.
We should do stdout=subprocess.PIPE, stderr=subprocess.STDOUT and check the return code because IIRC, zectl can dump errors to stdout or stderr.
yocalebo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zectl command on failure conditions will print to stderr rather than stdout. This means we were losing information about errors on bootenv operations.