When possible reuse websocket sessions in tests #12221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor optimization to open and use a single websocket client connection for the duration of the test. API consumers (for instance for HA tests) can import the PersistentCtx and run setup method with relevant arguments.
themylogin
reviewed
Oct 2, 2023
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def client(*, auth=undefined, auth_required=True, py_exceptions=True, log_py_exceptions=True, host_ip=None): | ||
| def client(*, auth=undefined, auth_required=True, py_exceptions=True, log_py_exceptions=True, host_ip=None, reuse_conn=True): | ||
| if reuse_conn and auth is undefined and host_ip is None and auth_required: |
There was a problem hiding this comment.
What about other parameters (e.g. related to exceptions)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor optimization to open and use a single websocket client connection for the duration of the test. API consumers (for instance for HA tests) can import the PersistentCtx and run setup method with relevant arguments.