Add coroutines support - Part II #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @wching
I have a question here...
do we really need to add coroutines here? We could just have a flow that doesn't depend on anything and it is pure kotlin and sync. What do you think?
| import java.util.Calendar | ||
|
|
||
| open class OAuth2AccessTokenManager( | ||
| private val mOAuth2AccessTokenStorage: OAuth2AccessTokenStorage |
There was a problem hiding this comment.
We can drop the m prefix here ;)
MarNwk
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
I created a package called coroutines. This package will contain every class that makes a reference to Kotlin coroutines.
Had to created the grants again with no reference to RxJava and adding the suspend keyword in the methods, whenever needed.