Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the golang version to 1.22.3 #7208

Merged
merged 2 commits into from May 13, 2024
Merged

Upgrade the golang version to 1.22.3 #7208

merged 2 commits into from May 13, 2024

Conversation

tanmayv25
Copy link
Contributor

We need this to install go-grpc which is a dependency in our L0_grpc test.

This is needed to fix the test.

Before

+ go install github.com/grpc-ecosystem/grpc-health-probe@latest
go: downloading github.com/grpc-ecosystem/grpc-health-probe v0.4.26
go: downloading google.golang.org/grpc v1.63.2
go: downloading github.com/spiffe/go-spiffe/v2 v2.2.0
go: downloading github.com/zeebo/errs v1.3.0
go: downloading google.golang.org/protobuf v1.33.0
go: downloading github.com/go-jose/go-jose/v4 v4.0.1
go: downloading golang.org/x/crypto v0.22.0
go: downloading golang.org/x/sys v0.19.0
go: downloading golang.org/x/sync v0.7.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240401170217-c3f982113cda
go: downloading golang.org/x/net v0.24.0
go: downloading golang.org/x/text v0.14.0
# github.com/go-jose/go-jose/v4
/root/go/pkg/mod/github.com/go-jose/go-jose/v4@v4.0.1/encoding.go:109:23: undefined: max
note: module requires Go 1.21

krishung5
krishung5 previously approved these changes May 10, 2024
kthui
kthui previously approved these changes May 11, 2024
@tanmayv25 tanmayv25 dismissed stale reviews from kthui and krishung5 via cad1623 May 13, 2024 19:07
@tanmayv25 tanmayv25 requested review from kthui and krishung5 May 13, 2024 22:21
@tanmayv25 tanmayv25 merged commit 4ea3a90 into main May 13, 2024
3 checks passed
@tanmayv25 tanmayv25 deleted the tanmayv-go branch May 13, 2024 22:26
tanmayv25 added a commit that referenced this pull request May 13, 2024
* Upgrade the golang version to 1.22.3

* Move to recommended go install method
mc-nv pushed a commit that referenced this pull request May 14, 2024
* Upgrade the golang version to 1.22.3

* Move to recommended go install method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants