add test for shape validation #7195
Merged
+156
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbkyang-nvi
force-pushed
the
kyang-validate-input-shapes
branch
from
b492572
to
005c650
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GuanLuo
reviewed
May 15, 2024
| RET=1 | ||
| fi | ||
| set -e | ||
|
|
||
| kill $SERVER_PID | ||
| wait $SERVER_PID | ||
|
|
||
| pip install torch |
There was a problem hiding this comment.
Why pytorch? Should be more flexible using Python backend
There was a problem hiding this comment.
This is taken from this reproducer
| FIXED_LAST_DIM = 8 | ||
|
|
||
|
|
||
| def repo_dir(): |
There was a problem hiding this comment.
Like the idea of moving all logic within Python, can this be common utils?
There was a problem hiding this comment.
Agree but will push back for now. This function needs to be generic then we can refactor other tests.
| # server.terminate() | ||
| # assert np.allclose( | ||
| # bob_result.as_numpy("OUTPUT0"), input_data_2 | ||
| # ), "Bob's result should be the same as input" |
There was a problem hiding this comment.
remove? I think anything past the assert is not needed
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_shape_overlapped(repo_dir: str): |
There was a problem hiding this comment.
Can you add summary on how the test operates?
yinggeh
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: triton-inference-server/core#350