Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support to intel gpu in a custom build #7047

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dtrawins
Copy link

@dtrawins dtrawins commented Mar 27, 2024

Additional build flag --enable-intel-gpu which includes in the docker image required runtime drivers for Intel GPU
Related to https://github.com/triton-inference-server/openvino_backend/pull/74/files

@dtrawins dtrawins marked this pull request as ready for review April 9, 2024 12:16
@tanmayv25
Copy link
Contributor

Don't we need to modify OpenVINO backend as well? I believe we were not installing openVINO GPU plugin.
Are we now supporting both discrete and integrated GPUs in Triton OpenVINO backend?

@ilya-lavrenov
Copy link

Agree, looks like at least this place need to be updated https://github.com/triton-inference-server/openvino_backend/blob/main/CMakeLists.txt#L213 (not sure why custom plugins.xml is required?)

@dtrawins
Copy link
Author

@tanmayv25 Related change in the openvino_backend is included in https://github.com/triton-inference-server/openvino_backend/pull/74/files
Merge is pending your review for this PR. If you are ok with this approach, the first step would be merging the support in the backend.

Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better way to enable backends to provide customizations without adding top level flags

@@ -1115,6 +1115,17 @@ def create_dockerfile_linux(

ENV LD_LIBRARY_PATH=/usr/local/tensorrt/lib/:/opt/tritonserver/backends/tensorrtllm:$LD_LIBRARY_PATH
"""
if FLAGS.enable_intel_gpu and ("openvino" in backends):
df += """
RUN apt-get update && apt-get install -y gpg-agent wget
Copy link
Contributor

@nnshah1 nnshah1 May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of docker file change - can this be handled in the cmake / build steps for the backend?

Thought:

Can we pass an a cmake variable to customize the build and pull this dependency in

(

server/build.py

Line 2343 in 0a543b8

parser.add_argument(

@tanmayv25 , @nv-kmcgill53 - woud this would also require some changes to how we install backends once build is complete? -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about having a setup script as a part of the backend repository? We can decide on a standardized approach common across all the backend. The build.py can then access this setup script to install all the runtime dependencies and prepare environment to use the backend.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of plug and play backends entails building backends at one place and then copying the backend libraries (*.so's) to the runtime environment with tritonserver and core.
Hence, having a script to setup env would help in all use-cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need some design work - but I like that idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants