Add reset option to support dispatching onOut event when removing #33
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
seriouslysean
commented
Mar 23, 2021
| @@ -0,0 +1 @@ | |||
| v10.24.0 | |||
There was a problem hiding this comment.
Allows switching to the correct node version with something like nvm use or n auto.
Comment on lines
+53
to
+54
| // Remove hoverintent and fire the out handler | ||
| hoverListener.remove(true); |
There was a problem hiding this comment.
Wasn't sure this was the right place for it, but wanted to show a real world usage. If this is intended as a snippet that can be copy/pasted, might be worth moving this to a different location.
| @@ -107,8 +107,12 @@ module.exports = function(el, onOver, onOut) { | |||
| el.removeEventListener('blur', dispatchBlur, false); | |||
| } | |||
|
|
|||
| h.remove = function() { | |||
| h.remove = function(reset) { | |||
There was a problem hiding this comment.
New param; if this is true the mouse out event will fire before removing the event listeners.
Comment on lines
+6
to
+9
| "engine-strict": true, | ||
| "engines": { | ||
| "node": "^10.0.0" | ||
| }, |
There was a problem hiding this comment.
Will require the correct node version so that the build script runs properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #21 -- alternate solve to what #32 is doing.
--
This PR adds the option to
resetthe hoverintent usage whenremovetakes places. This optionally fires theonOutevent to do any sort of cleanup required. The option is passed as a parameter to theremoveevent to keep things colocated where possible.Also added an
.nvmrcfile with the recommended node version and the properengineentries to thepackage.jsonfiles as the build function only ran in node version < 11.