Shutdown ThriftTpchService in thrift connector tests #21936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with ability to attach resources to DistributedQueryRunner, reusing existing code there.
findepi
added
test
no-release-notes
`ThriftTpchService` / `ThriftIndexedTpchService` needs to be closed. Let's close them to prevent resource leak.
findepi
force-pushed
the
findepi/shutdown-thrifttpchservice-in-thrift-connector-tests-4be40a
branch
from
0c90150
to
2036e26
Compare
wendigo
approved these changes
May 11, 2024
findepi
deleted the
findepi/shutdown-thrifttpchservice-in-thrift-connector-tests-4be40a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThriftTpchService/ThriftIndexedTpchServiceneeds to be closed.Let's close them to prevent resource leak.
Found by #21913