Separate schemas in BaseSharedMetastoreTest #21909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
May 10, 2024
|
|
||
| assertUpdate("CREATE SCHEMA " + schemaName); |
There was a problem hiding this comment.
Maybe let's fix or isolate testShowTables instead, rather than require every test to create new schema.
testShowTables can be isolated at execution, or by creating a new schema in that test
or fixed by relaxing assertions
There was a problem hiding this comment.
Updated the tests to create 2 schemas in createQueryRunner because other tests (e.g. testReadInformationSchema, testShowSchemas) also depend on the existing schema.
ebyhr
force-pushed
the
ebi/iceberg-fix-test
branch
2 times, most recently
from
814b4eb
to
4a7778b
Compare
ebyhr
changed the title
Some tests expect only region and nation tables exist in the schema.
ebyhr
force-pushed
the
ebi/iceberg-fix-test
branch
from
4a7778b
to
73a74b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tests expect only region and nation tables exist in the schema
Fixes #21962
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.