New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify register_table requirement #21874
base: master
Are you sure you want to change the base?
Conversation
Also fyi @kpayne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar nits for the commas (you only put a comma before a conjunction if what follows the conjunction is an independent clause), but LGTM
1d3ff52
to
265d873
Compare
- Add info that it has to be enabled in the catalog - Delta Lake and Iceberg connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo
#### Register table | ||
|
||
The connector can register table into the metastore with existing transaction | ||
logs and data files. | ||
The connector can register existing Delte Lake tables into the metastore if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delta Lake
Description
This seems to have caught numerous users off guard. Maybe we should change the default to true in the longer run .. but at least this doc is required. Also I am only assuming that this also applies to unregister .. maybe @findinpath and @ebyhr can confirm?
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.