Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pushdown of a few aggregation functions for ClickHouse Connector #21840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sylph-eu
Copy link
Contributor

@sylph-eu sylph-eu commented May 7, 2024

Description

Partially addresses #7100.

This PR enables a pushdown of the following aggregation functions: COUNT(DISTINCT) (except varchars), COVARIANCE, and CORRELATION.

Implementation of the rest of the functions have certain nuances that require additional efforts:

  • Decimal implementation truncates digits outside of the scale, while Trino rounds them up.
  • Statistical functions return NaN values on empty sets, while Trino expects NULL.

I'll have a look whether limitations above can be workarounded to improve pushdown "coverage".

Additional context and related issues

Continuous work on #7100.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( X) Release notes are required, with the following suggested text:

# Section
* Pushdown more aggregation functions for ClickHouse connector. ({https://github.com/trinodb/trino/issues/7100}`7100`)

@cla-bot cla-bot bot added the cla-signed label May 7, 2024
@github-actions github-actions bot added the docs label May 7, 2024
@sylph-eu sylph-eu changed the title Clickhouse connector 5 Enable pushdown of a few aggregation functions for ClickHouse Connector May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant