Use Nimbus OAuth SDK for OIDC #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
May 20, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
Outdated
Show resolved
Hide resolved
Validate URI in config for early error detection.
oneonestar
force-pushed
the
star/refactor_oidc
branch
from
6e8649d
to
304cee5
Compare
oneonestar
force-pushed
the
star/refactor_oidc
branch
from
304cee5
to
9944367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Nimbus OAuth SDK for OIDC. The same SDK is also used by Trino.
This is only a refactoring. Security issues related to OIDC will be addressed in another PR.
Ref: https://connect2id.com/products/nimbus-oauth-openid-connect-sdk/examples/openid-connect/token-request
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.