-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional volume and volume mount is not working #152
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bhargav Akhani.
|
When I put this in values:
and render template I get
seems fine to me |
@losipiuk Can we please merge it? So, I can use this in my production. |
@LittleWat @huw0 @florianMalbranque @ryan0x44 Please take a look. |
@bhargav2427 I'm using the 0.19.0 chart successfully with both ConfigMap and PVC mounts. What version of helm are you using? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhargav2427 can you rebase? I also recently added some new tests, maybe you could update https://github.com/trinodb/charts/blob/main/test-values.yaml and configure some additional volumes there, so we can make sure this works correctly.
{{- with .Values.worker.additionalVolumeMounts }} | ||
{{- . | toYaml | nindent 12 }} | ||
{{- end }} | ||
{{- toYaml .Values.coordinator.additionalVolumeMounts | nindent 12 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{- toYaml .Values.coordinator.additionalVolumeMounts | nindent 12 }} | |
{{- toYaml .Values.worker.additionalVolumeMounts | nindent 12 }} |
{{- with .Values.worker.additionalVolumes }} | ||
{{- . | toYaml | nindent 8 }} | ||
{{- end }} | ||
{{- toYaml .Values.coordinator.additionalVolumes | nindent 8 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{- toYaml .Values.coordinator.additionalVolumes | nindent 8 }} | |
{{- toYaml .Values.worker.additionalVolumes | nindent 8 }} |
I checked and additionalVolumes and additionalVolumeMounts option of coordinator and worker is not working. After these changes, I can see the volumes and volumeMounts in
helm template
.