Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional user defined ConfigMaps #107

Merged
merged 1 commit into from
May 26, 2024

Conversation

huw0
Copy link
Member

@huw0 huw0 commented Nov 4, 2023

Presently the chart supports only user defined secret mounts. This PR adds support for additional user defined config mounts.

I am only just getting started with trino but my use case for this at the moment is to mount a truststore for certificate authentication that is provided as a cluster wide config map.

Copy link

cla-bot bot commented Nov 4, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@martint
Copy link
Member

martint commented Nov 9, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 9, 2023
Copy link

cla-bot bot commented Nov 9, 2023

The cla-bot has been summoned, and re-checked this pull request!

@huw0
Copy link
Member Author

huw0 commented Mar 4, 2024

#129 means that it is now possible to mount additional ConfigMaps.
Leaving this open though as it seems there is still benefit given that secretMounts still exists.

@nineinchnick
Copy link
Member

@huw0 can you rebase, please?

@huw0 huw0 force-pushed the support-additional-configmaps branch 5 times, most recently from 87d7efd to 99393bc Compare May 25, 2024 17:03
@huw0 huw0 force-pushed the support-additional-configmaps branch from 99393bc to 2f35981 Compare May 25, 2024 17:05
@huw0
Copy link
Member Author

huw0 commented May 25, 2024

@nineinchnick now rebased

@nineinchnick nineinchnick merged commit 35515cf into trinodb:main May 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants