Skip to content

Commit

Permalink
Fix default value for additionalJVMConfig
Browse files Browse the repository at this point in the history
`additionalJVMConfig` expects a list, so the default value should not be an empty object.
  • Loading branch information
heitorrbarros authored and nineinchnick committed May 10, 2024
1 parent a3a62a1 commit 3239a09
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/trino/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ The following table lists the configurable parameters of the Trino chart and the
| `coordinator.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
| `coordinator.config.memory.heapHeadroomPerNode` | | `""` |
| `coordinator.config.query.maxMemoryPerNode` | | `"1GB"` |
| `coordinator.additionalJVMConfig` | | `{}` |
| `coordinator.additionalJVMConfig` | | `[]` |
| `coordinator.additionalExposedPorts` | | `{}` |
| `coordinator.resources` | | `{}` |
| `coordinator.livenessProbe` | | `{}` |
Expand All @@ -85,7 +85,7 @@ The following table lists the configurable parameters of the Trino chart and the
| `worker.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
| `worker.config.memory.heapHeadroomPerNode` | | `""` |
| `worker.config.query.maxMemoryPerNode` | | `"1GB"` |
| `worker.additionalJVMConfig` | | `{}` |
| `worker.additionalJVMConfig` | | `[]` |
| `worker.additionalExposedPorts` | | `{}` |
| `worker.resources` | | `{}` |
| `worker.livenessProbe` | | `{}` |
Expand Down
4 changes: 2 additions & 2 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ coordinator:
query:
maxMemoryPerNode: "1GB"

additionalJVMConfig: {}
additionalJVMConfig: []

additionalExposedPorts: {}

Expand Down Expand Up @@ -335,7 +335,7 @@ worker:
query:
maxMemoryPerNode: "1GB"

additionalJVMConfig: {}
additionalJVMConfig: []

additionalExposedPorts: {}

Expand Down

0 comments on commit 3239a09

Please sign in to comment.