Remove the unused "transient" block adapter #7663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
bug
It is unused. _Sic transit gloria mundi_, I guess.
arielshaqed
force-pushed
the
chore/remove-transient-block-adaptor
branch
from
9afd0df
to
930ae1f
Compare
There should never be any communication with a "transient" block adapter - it _literally_ ignores and fails everything. So this is not a breaking change, except perhaps for a system test that tests a client with a broken lakeFS server. We do not have such a test.
|
🎊 PR Preview af712e8 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7663.surge.sh 🕐 Build time: 0.013s
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
Jonathan-Rosenberg
approved these changes
Apr 11, 2024
|
Only thing blocking this is that we kinda break OpenAPI compatibility, because we remove the option to have "transient". It doesn't matter, but I'm also very willing to keep "transient" in swagger.yml and just make it an alias to |
|
This PR is now marked as stale after 30 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label. |
|
Closing this PR because it has been stale for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unused. Sic transit gloria mundi, I guess.