Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command to open popup #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WofWca
Copy link

@WofWca WofWca commented Apr 30, 2023

Advantages:

  • More convenient to open the extension popup, for example, if you want to translate a manually imput text.
  • In Chromium browsers if the extension "Site access" is set to "On click", this makes a great combination with the "Auto translate" feature. When you visit a site that you want to translate, you can do so by executing the shortcut.
  • Generally good for keyboard users.

For reference, my extension has this as well, and I use it exclusively, it's very convenient
https://github.com/WofWca/jumpcutter/blob/d5727fed31bb3b1a654b76ddf38d90ebd6a384e2/src/manifest.json#L35C1-L47

Related: #266, #117 (comment)

Advantages:
* More convenient to open the extension popup, for example,
if you want to translate a manually imput text.
* In Chromium browsers if the extension "Site access" is set to
"On click", this makes a great combination with the "Auto translate"
feature. When you visit a site that you want to translate, you can
do so by executing the shortcut.
* Generally good for keyboard users.
@vitonsky
Copy link
Collaborator

Linguist already support shortcuts to translate page

image


If you still need this feature, please create new issue first and describe your use case and let's discuss how it should works.
Then you can implement feature in this MR if you want, but we have to bind issue number for each pull request.

Keep in mind that UX principles in Linguist oblige us to make any shurtcuts are custumizable, not hardcoded

@WofWca
Copy link
Author

WofWca commented Apr 30, 2023

If you still need this feature, please create new issue first

Is it OK to discuss it in #117?

but we have to bind issue number for each pull request.

TBH I don't like such a policy.

@vitonsky
Copy link
Collaborator

but we have to bind issue number for each pull request.

TBH I don't like such a policy.

This rule is necessary to ensure project maintainability, thus it is not for discuss and we have to obey this rule to pull request will accepted

@vitonsky
Copy link
Collaborator

If you still need this feature, please create new issue first

Is it OK to discuss it in #117?

Of course. But if you will implement only shortcut to open popup, we have to introduce new issue and bind it with your pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants