Move duplicate functions #145
Conversation
- Move custom `expect_` functions out of `dataset_test`, into R/test_functions.R so that R CMD check warnings are removed - Rename prefixes to `test_`
|
|
||
| # Expected output | ||
| tables <- c("traits", "locations", "contexts", "methods", "excluded_data", | ||
| "taxonomic_updates", "taxa", "contributors") | ||
| expect_no_error( | ||
| expected_output <- | ||
| purrr::map( | ||
| tables, ~read_csv(sprintf("examples/Test_2023_8/output/%s.csv", .x), col_types = cols(.default = "c"))), | ||
| info = "Reading in expected output tables" |
There was a problem hiding this comment.
Why delete? The info isn't helpful?
There was a problem hiding this comment.
It's using expect_no_error from {testthat} which does not accept an info argument.
There was a problem hiding this comment.
Ok, but you also had a new function defined called expect_no_error, which would overwrite the one from {test that}. Now it's renamed to test_ expect_no_error, so perhaps isn't being used?
There was a problem hiding this comment.
Oh there shouldn't have been a new function defined called expect_no_error; if there was- that's my bad!
I can't seem to find it though. I did a find and replace on test_ to test_expect_ before so theoretically I shouldn't have touched expect_no_error.
|
@dfalster I should have explained clearer but basically |
Ok! |
dataset_testandtests#131expect_functions out ofdataset_test, into R/test_functions.R so that R CMD check warnings are removed (otherwise "no visible global function definition" warning comes up)test_expect_to differentiate between customtestthatfunctions and built-intestthatfunctionsexpect_silent()from {testthat} instead of writing a custom function because I'm not sure how to rewrite the function to capture messages on top of errors and warnings