Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new study: Zeppel_2008 #731

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

Add new study: Zeppel_2008 #731

wants to merge 33 commits into from

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Jun 15, 2023

  • add new study
  • Gillian transcribed from manuscript

ehwenk and others added 22 commits May 25, 2023 12:21
* Adding 7 studies with morphological trait data extracted from 7 state and national floras: "SAH_2023", "WAH_2023_1", "WAH_2023_2", "ABRS_2023", "RBGV_2023", "NHNSW_2023", "NTH_2023"

* 30 traits added

* trait values mostly mapped to those developed in vocabulary workshops, but a few additional terms were needed, especially for traits like leaf_base for which we previously had very little data

* branch also includes some preliminary work on fire response traits and edits to water use/hydraulics traits
---------
Co-authored-by: David Coleman <https://github.com/dcol2804>
Co-authored-by: Sophie Yang <78716301+yangsophieee@users.noreply.github.com>
Add large dataset on fire response, seed longevity and reproductive maturity of most taxa in the Northern Territory Herbarium database, compiled from the literature and expert review.
Lizzy emailed the report to the author but he's on leave so merging now! 

---------

Co-authored-by: ehwenk <ehwenk@gmail.com>
Add 3 new studies from Nadia Santini looking at water relations
Contributor has submitted her raw data files and reviewed all reports
---------

Co-authored-by: Sophie Yang <78716301+yangsophieee@users.noreply.github.com>
Add study examining how resprouting and propagule persistence are associated with grassland and shrubland habitats and other environmental and biotic variables. Lizzy has emailed the author and we are awaiting a response.

---------

Co-authored-by: ehwenk <ehwenk@gmail.com>
Add study with seed storage location and fire response data (both resprouting and seedling recruitment) at the plot level after experimental fire treatments. The study also investigated density changes after fire, which I have not mapped.

---------

Co-authored-by: ehwenk <ehwenk@gmail.com>
* edits to traits related to fire response and plant regeneration following one of the AusTraits vocabulary workshops
* major change is renaming all `fire_response` related traits to `resprouting_capacity`
* removing several derived traits that can be recreated from other trait values; in the coming 6 months we will create some scripts showing how current data can be analysed
* remap values for some traits in NSWFRD_2014 to capture more data
---------

Co-authored-by: Sophie Yang <78716301+yangsophieee@users.noreply.github.com>
* add new study: Mitchell_2008
* no contact with data collector
* some problems with archived data - for instance Kl data are identical to Ks, so not used.
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* add new study: Kocacinar_2003
* contacted authors for additional traits and individual-level data, but haven't heard back, so merging in data that are available in the manuscript
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* old study and data extracted from tables and figures in paper
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* add new study
* data transcribed from manuscript & author not contacted

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* Add new study: Britton_1994
* First study with recruitment_time
* transcribed data from manuscript; no contact with author
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* Add new study: Cowling_1987
* data on germination & flowering relative to fire for 4 WA Banksia species
* data transcribed from manuscript; no contact with author

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* Add new study: Auld_2000
* dataset with seedbank longevity half-lives
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* edit metadata_create_template to add proper fields for data_collectors
* Tweak and add tests

---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
* Add new study: Tsakalos_2022
* large dataset documenting clonal spread mechanisms and bud bank locations for WA taxa
* dataset available online, but will contact author
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* Add new study: Brodribb_2000

* data transcribed from manuscript
* author not contacted, as this is an older study
---------
Co-authored-by: GillianKowalick 

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* Add new study: Collette_2021
* Large study looking at seed dormancy across Australia
* Data from supplementary material; authors have not yet responded to email
---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
* add new study
* data transcribed from paper

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
Add study on growth and storage traits of post-fire seedlings in Mediterranean ecosystems of south-western Australia. I originally transcribed it in long format because that was easiest, but I changed it into wide format (see Pate_1990_extra_R_code.R) because there were some warning messages associated with it being in long format.

---------

Co-authored-by: ehwenk <ehwenk@gmail.com>
@ehwenk ehwenk requested a review from yangsophieee June 15, 2023 10:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d8404a9) 79.52% compared to head (b5ff8ab) 79.52%.

❗ Current head b5ff8ab differs from pull request most recent head 1b05c64. Consider uploading reports for the commit 1b05c64 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #731   +/-   ##
========================================
  Coverage    79.52%   79.52%           
========================================
  Files            7        7           
  Lines         1548     1548           
========================================
  Hits          1231     1231           
  Misses         317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dcol2804 and others added 6 commits June 19, 2023 14:43
* Flora data fixes

Covering 2022 traits which are in the current release and 2023 traits which will be in the next version.

* Aligned the growth form and woodiness to correct version
* script to generate traits.yml from APD data files (APD_traits.csv & APD_categorical_values.csv)

* APD files are pulled directly from github APD repository

* use script to updates traits.yml from APD version 1.0.0

ensure in final version of traits.yml (in the future):
- ''' (3 single quotes) don't exist; should be ' (1 single quote)
-  there are no instances of `allowed_values_levels: {}`

closes issue #727 
---------

Co-authored-by: Daniel Falster <daniel.falster@unsw.edu.au>
add study - seed germination data from Kings Park, WA botanic garden

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
- Added additional raw data files from Caroline Nano for NT fire response
- Filtered out duplicate taxa for `resprouting_capacity` data from Simpson_2021 (where it cites Crowley_2007)

---------

Co-authored-by: ehwenk <ehwenk@gmail.com>
Small dataset of bark thickness index values. There is a lot more raw data supposedly in the study but we decided to not contact the author.

---------

Co-authored-by: Elizabeth Wenk <ehwenk@gmail.com>
* add 3 traits to scraped data files, `plant_photosynthetic_organ`, `leaf_lamina_posture` and `leaf_margin_posture` to scraped flora data files

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
config/unit_conversions.csv Outdated Show resolved Hide resolved
data/Zeppel_2008/metadata.yml Outdated Show resolved Hide resolved
data/Zeppel_2008/metadata.yml Outdated Show resolved Hide resolved
data/Zeppel_2008/metadata.yml Show resolved Hide resolved
ehwenk and others added 3 commits June 22, 2023 17:09
Small study looking at reproductive characteristics of 3 Banksia species in relation to fire

---------

Co-authored-by: yangsophieee <sophie.yang917@gmail.com>
@ehwenk
Copy link
Collaborator Author

ehwenk commented Jun 22, 2023

This dataset has been reviewed and is ready to merge in. However, we'll leave it open for now, as I have just contacted the author to request the raw dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants